• AbstractServerTaskExt.getNthArgument()

    By Harald Albers 1 decade ago

    A problem in an out-of-bounds check leads to AbstractServerTaskExt.getNthArgument() always returning null.

    This patch resolves the issue:

     

     

    Index: src/org/openntf/javaddin/task/AbstractServerTaskExt.java
    
    ===================================================================
    
    --- src/org/openntf/javaddin/task/AbstractServerTaskExt.java (revision 4)
    
    +++ src/org/openntf/javaddin/task/AbstractServerTaskExt.java (working copy)
    
    @@ -115,7 +115,7 @@
    
      return null;
    
      }
    
      
    
    - if ( orderedArgs.size() >= n ){
    
    + if ( n >= orderedArgs.size() ){
    
      return null;
    
      }
    
      
    
    
        Index: src/org/openntf/javaddin/task/AbstractServerTaskExt.java</div>
    
        ===================================================================</div>
    
        <span style="font-family:courier new,courier,monospace;">--- src/org/openntf/javaddin/task/AbstractServerTaskExt.java (revision 4)</span></div>
    
        <span style="font-family:courier new,courier,monospace;">+++ src/org/openntf/javaddin/task/AbstractServerTaskExt.java (working copy)</span></div>
    
        @@ -115,7 +115,7 @@</div>
    
        <span style="font-family:courier new,courier,monospace;">&nbsp; return null;</span></div>
    
        <span style="font-family:courier new,courier,monospace;">&nbsp; }</span></div>
    
        <span style="font-family:courier new,courier,monospace;">&nbsp; </span></div>
    
        <span style="font-family:courier new,courier,monospace;">- if ( orderedArgs.size() &gt;= n ){</span></div>
    
        <span style="font-family:courier new,courier,monospace;">+ if ( n &gt;= orderedArgs.size() ){</span></div>
    
        <span style="font-family:courier new,courier,monospace;">&nbsp; return null;</span></div>
    
        <span style="font-family:courier new,courier,monospace;">&nbsp; }</span></div>
    
        &nbsp; </div>
    
        &nbsp;</div>
    

  • Good catch

    By David D Taieb 1 decade ago

    I'll provide a fix in 1.5.

    Thank you

    -david