• Remove unused lookup in Admin Approve action

    By John Smart 2 decades ago

    In the Leave Request form's "Approve A/L - Admin" action, the following variables are unused and should be commented out/removed:



    WEdays

    LocView

    LocDoc



    I had stumbled upon this after trying to get rid of Region & Location documents and I got an Object Variable Not Set error because "Set LocDoc = LocView.getdocumentbykey(tmpLeavLoc)" left LocDoc as Nothing, so "WEdays = Implode(LocDoc.WEDays)" caused an error.

    • They Are Used

      By Bob Brodsky 2 decades ago

      Hi John,



      Thanks again for your interest in Vacation Request!



      LocDoc is used to determine WeekEnd Days which do not count as annual leave. Different cultures have different definitions of what a weekend is. Also, some job situations don't allow for any weekends–all days off must be approved.



      Rather than getting rid of these documents if you do not need them please consider assigning all of your people to the same Location. Region is optional.



      HTH,

      Bob

      • Not in the action

        By John Smart 2 decades ago

        I agree that Location documents are used but not in that particular action button. LocDoc and WEDays, judging by the LotusScript comments, were formerly used, but now if I schedule a vacation for a solid two weeks, 14 individual AR docs are created regardless of weekends.



        Then again, maybe I have an old version? I think I'm using 2.2.7.c

        • I'll Look Into It

          By Bob Brodsky 2 decades ago

          John,



          Thanks again for your interest in Vacation Request!



          I'll look into removing the need for the lookup to Location documents in the Admin Approve button process. Once I allowed Weekend days to vary by Location I did start putting the weekend leave days on the Leave Calendar (ALs) even though they did not count as annual leave. Look for the update in release 2.2.8. I'll need some time for the update and more for the testing…



          Release 2.2.7e is current and has a few fixes from 2.2.7c



          Bob