• Remove 'alert()' functions in javascript

    By F. Kranenburg 1 decade ago

    Within Tabs.js I see javascript 'alert()' functions that display errors. Could you please remove the alert functions and replace them with 'console.log' functions or something?

    The reason for this is we use the Tabcontainer without closeable tabs. It looks like the 'onclose' events are being fired anyway when the user navigates away or full refreshes the page. They get an error dialog saying 'xhr cancelled'.

    • alert have been replaced

      By Philippe Riand 1 decade ago

      The change will be in the next build (not 11/19)

      But I'm curious to see when the error happens. Can you please send me a reproducible case? It might require an actual fix to fully prevent the event.

      • Sample database

        By F. Kranenburg 1 decade ago

        Thanks for fixing it, but it may be an issue that must be fixed. I have created a NSF on 8.5.3 client en tested it with IE9.

        On page load and when I navigate away throught the page to another page, the 'xhr canceled' dialog pops up. We use the tab control with exactly these options in the tabcontainer in our commercial product.

        I really hope you can fix it! Thanks!

        • Your sample works for me

          By Philippe Riand 1 decade ago

          with IE8 & IE9. How am I supposed to reproduce the issue?

          • Disable script debugging

            By F. Kranenburg 1 decade ago

            You should turn off the 'disable script debugging' feature in IE. The messages will appear inside the script console (developer window).

            • Sorry can't reproduce

              By Philippe Riand 1 decade ago

              And I'm not seeing anything in the console. Can you please to debug it on your side and let us know if you find a solution?

              • maybe...

                By F. Kranenburg 1 decade ago

                It should be reproduceable by clicking some tabs and then click on the 'navigate to next page' link. The console will log the errors like in this screenshot. I'm currently using an older version of the extension library where the 'alert' functions are still there. Maybe if you temporary put the alert functions back, the console will log the errors.

                The fix suggested by me, to replace them by console.log functons will not log to the console in IE9. This can also be the reason why you can't reproduce the problem.